Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

Make English version the default#316

Closed
juliecbd wants to merge 2 commits intoPaddlePaddle:developfrom
juliecbd:make_en_default
Closed

Make English version the default#316
juliecbd wants to merge 2 commits intoPaddlePaddle:developfrom
juliecbd:make_en_default

Conversation

@juliecbd
Copy link
Contributor

No description provided.

@juliecbd juliecbd requested review from luotao1 and reyoung May 17, 2017 00:18
@reyoung
Copy link
Collaborator

reyoung commented May 17, 2017

Hello @juliecbd ,

There are several things need to know when contributing to book repository.

  • Just like other repositories in PaddlePaddle organization, we are using pre-commit tools to check code style, automatically building HTML file, etc. Please install pre-commit tool first.
  • In Book repository, we using pre-commit to compile markdown file into html file. Here is the regex pattern for matching files.
  • Also, we are using jinja2 template to compile the front page. Here is the template files of front pages.

And I just pushed another commit to your repository make TravisCI happy.

@luotao1
Copy link
Collaborator

luotao1 commented May 17, 2017

Hello @juliecbd , #315 modify the install url in all chapters. After this PR, some urls may be dead. Please check all the urls in next PR.

@wangkuiyi
Copy link
Collaborator

wangkuiyi commented May 17, 2017

Hi @luotao1, @juliecbd was asking, but I didn't understand your remind either. When you said "After this PR", were you referring to #315 or #316?

I read that you fixed some URLs in #315. Does that imply that @juliecbd should redo #316 after #315 is merged, so that those fixed URLs appear in files renamed by #316?

@wangkuiyi
Copy link
Collaborator

@reyoung Thanks for the remind about pre-commit and the refresh of HTML files.

I have a question not tightly related with this PR -- should we include HTML files in this repo? Or, we can generate them when we deploy this repo to the server paddlepaddle.org?

@luotao1
Copy link
Collaborator

luotao1 commented May 18, 2017

@wangkuiyi @juliecbd

Does that imply that @juliecbd should redo #316 after #315 is merged, so that those fixed URLs appear in files renamed by #316?

Yes, should redo #316 , since those fixed URLs will be disappeared.

@luotao1
Copy link
Collaborator

luotao1 commented May 19, 2017

close due to #318

@luotao1 luotao1 closed this May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants