Remove unused cost parameter in ParameterUpdater#970
Merged
reyoung merged 1 commit intoPaddlePaddle:developfrom Dec 21, 2016
Merged
Conversation
Collaborator
|
赞！ @reyoung |
jacquesqiao
reviewed
Dec 21, 2016
| virtual void startPass() {} | ||
|
|
||
| // called by Trainer then finishing a pass, ruturn true if pass accepted | ||
| virtual bool finishPass(real cost = 0) { return true; } |
Member
There was a problem hiding this comment.
这个 cost一开始是用来做啥的，看起来是记录了每一个batch的cost，现在是使用另外一个机制替代了么
qingqing01
approved these changes
Dec 21, 2016
zhhsplendid
pushed a commit
to zhhsplendid/Paddle
that referenced
this pull request
Sep 25, 2019
* break up layers and change index of layers * prettify script
zhangyuqin1998
pushed a commit
to zhangyuqin1998/Paddle
that referenced
this pull request
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.