Skip to content

change WITH_FLUID to WITH_FLUID_ONLY#9427

Merged
abhinavarora merged 2 commits intoPaddlePaddle:developfrom
luotao1:with_only_fluid
Mar 29, 2018
Merged

change WITH_FLUID to WITH_FLUID_ONLY#9427
abhinavarora merged 2 commits intoPaddlePaddle:developfrom
luotao1:with_only_fluid

Conversation

@luotao1
Copy link
Contributor

@luotao1 luotao1 commented Mar 28, 2018

change WITH_FLUID to WITH_FLUID_ONLY, which is much matching to its meaning.

@luotao1 luotao1 requested a review from wangkuiyi March 28, 2018 04:20
CMakeLists.txt Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WITH_FLUID_ONLY might make more sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinavarora You are right, I change to WITH_FLUID_ONLY now.

@luotao1 luotao1 changed the title change WITH_FLUID to WITH_ONLY_FLUID Mar 28, 2018
@luotao1
Copy link
Contributor Author

luotao1 commented Mar 29, 2018

@abhinavarora Could you help review again?

Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abhinavarora abhinavarora merged commit 9bbd753 into PaddlePaddle:develop Mar 29, 2018
mikeseven added a commit to mikeseven/Paddle that referenced this pull request Mar 30, 2018
* commit '33b8b3d22034423455a493712955e419aac7b19b': (251 commits)
  Remove redundant commands in build.sh and build_doc.sh
  Add dependencies
  Move v2/api/fluid to fluid/api and Adjust doc build commands
  Plain LRN op throws an exception when is_test is set in backward pass
  fix compiler error of profiler_test in ONLY_CPU mode
  fix server shutdown
  Translation for Model Configuration (PaddlePaddle#9513)
  Fix data transform when inplace (PaddlePaddle#9450)
  refine parallel
  add FAQ (PaddlePaddle#9494)
  Fix dist error with lr decay layer (PaddlePaddle#9489)
  add prefetch_op (PaddlePaddle#9495)
  Fix some errors (PaddlePaddle#9403)
  hookup WITH_FLUID_ONLY in TeamCity build.sh (PaddlePaddle#9509)
  Fix the order of reads and write from buffered channel  (PaddlePaddle#9423)
  change WITH_FLUID to WITH_FLUID_ONLY (PaddlePaddle#9427)
  fix block num
  Revert "make append activation in place by default (PaddlePaddle#9417)"
  Speed/sequence op1 (PaddlePaddle#9217)
  fix a compile error
  ...
@luotao1 luotao1 deleted the with_only_fluid branch June 11, 2018 12:05
blacksheep-Aristotle pushed a commit to blacksheep-Aristotle/Paddle that referenced this pull request Nov 22, 2024
…dle#9427)

* Fix row parallel lora layers parameters initialization bug

* Fix ColumnParallel LoRA layers

* Fix QuantLora param init bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants