Skip to content

fix submit_local's paddle pip name issue#9392

Merged
luotao1 merged 1 commit intoPaddlePaddle:developfrom
putcn:fix-submit-local
Mar 28, 2018
Merged

fix submit_local's paddle pip name issue#9392
luotao1 merged 1 commit intoPaddlePaddle:developfrom
putcn:fix-submit-local

Conversation

@putcn
Copy link
Contributor

@putcn putcn commented Mar 26, 2018 •
edited by luotao1
Loading

fix: #9391
fix #7476

the issue is about syntax issue when run the default command "paddle version" from production docker image.

[root@k8s-node1 ~]# docker run --rm -it putcn/paddle:pro
/usr/local/bin/paddle: line 158: [: 0.10.0: binary operator expected
  File "<stdin>", line 3
    if LooseVersion("0.10.0
                          ^
SyntaxError: EOL while scanning string literal

the fix is to adding a pair of missing quote, and corrected the logic grabbing the current paddle version
@putcn putcn added the Docker label Mar 26, 2018
@putcn putcn requested review from luotao1 and reyoung March 26, 2018 23:20
luotao1
luotao1 approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have tested paddle version, which shows normally now.
@luotao1 luotao1 merged commit ab41c5d into PaddlePaddle:develop Mar 28, 2018
@putcn putcn deleted the fix-submit-local branch April 25, 2018 00:20
blacksheep-Aristotle pushed a commit to blacksheep-Aristotle/Paddle that referenced this pull request Nov 22, 2024
@DesmonDay
[Unified Checkpoint] Support sharding_comm_overlap (PaddlePaddle#9392)
921fc44 
* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docker

2 participants

@putcn @luotao1