Skip to content

Profiler can get elapsed time of sendop#9345

Merged
gongweibao merged 7 commits intoPaddlePaddle:developfrom
gongweibao:fixsendrecv
Mar 24, 2018
Merged

Profiler can get elapsed time of sendop#9345
gongweibao merged 7 commits intoPaddlePaddle:developfrom
gongweibao:fixsendrecv

Conversation

@gongweibao
Copy link
Contributor

@gongweibao gongweibao commented Mar 24, 2018 •
edited
Loading

Fix #9344

It's a temp resolution about #9052.
@gongweibao gongweibao requested a review from kuke March 24, 2018 02:35
@gongweibao gongweibao changed the title Fixsendrecv Mar 24, 2018
kuke
kuke approved these changes Mar 24, 2018
View reviewed changes
Copy link
Contributor

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kuke
Copy link
Contributor

kuke commented Mar 24, 2018 •
edited
Loading

I guess you need to add the dependency to the cmake list file to pass CI

Paddle/paddle/fluid/operators/CMakeLists.txt

Lines 190 to 199 in c83dd9b

op_library(cond_op DEPS framework_proto tensor net_op)
op_library(cross_entropy_op DEPS cross_entropy)
op_library(softmax_with_cross_entropy_op DEPS cross_entropy softmax)
op_library(softmax_op DEPS softmax)
op_library(sequence_softmax_op DEPS softmax)
op_library(sum_op DEPS selected_rows_functor)
op_library(sgd_op DEPS selected_rows_functor)
op_library(print_op DEPS lod_tensor)
op_library(adagrad_op DEPS selected_rows_functor)
op_library(maxout_op DEPS maxouting)

Try to append this line:

op_library(send_op DEPS profiler)
@gongweibao gongweibao merged commit cffe1a9 into PaddlePaddle:develop Mar 24, 2018
@gongweibao gongweibao deleted the fixsendrecv branch March 24, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@gongweibao @kuke