Skip to content

"polish code"#9318

Merged
dzhwinter merged 4 commits intoPaddlePaddle:developfrom
dzhwinter:fix/devices
Apr 2, 2018
Merged

"polish code"#9318
dzhwinter merged 4 commits intoPaddlePaddle:developfrom
dzhwinter:fix/devices

Conversation

@dzhwinter
Copy link
Contributor

polish executor python code

self.executor = core.Executor(act_places[0])
def __init__(self, place):
self.executor = core.Executor(place)
self.places = places
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

places is removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

self.executor = core.Executor(p)
self.program_caches = dict()

def aslodtensor(self, data):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm removing parsing lod is OK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We plan to use the nested numpy array to represent a LodTensor, but now we use two structure to do the same thing-- an array of data, a list of lod.

@dzhwinter dzhwinter merged commit 6cfc0c1 into PaddlePaddle:develop Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants