Memory optimization for fit a line demo#7321
Closed
QiJune wants to merge 7 commits intoPaddlePaddle:developfrom
Closed
Memory optimization for fit a line demo#7321QiJune wants to merge 7 commits intoPaddlePaddle:developfrom
QiJune wants to merge 7 commits intoPaddlePaddle:developfrom
Conversation
reyoung
reviewed
Jan 8, 2018
| # print(block_size) | ||
|
|
||
| # TODO(qijun) handle Program with if/while operators | ||
| self.global_block = program_desc.block(0) |
Collaborator
There was a problem hiding this comment.
We can just handle memory optimization for each block and do not optimize the memory between block. It may be enough.
wangkuiyi
approved these changes
Jan 9, 2018
| for (auto& op_desc : block.AllOps()) { | ||
| auto op = paddle::framework::OpRegistry::CreateOp(*op_desc); | ||
| VLOG(3) << op->DebugStringEx(local_scope); | ||
| VLOG(3) << "Memory used " << memory::memory_usage(place_); |
Collaborator
There was a problem hiding this comment.
Do we need a little more details in this log message, e.g., “before ....” or “after ...”?
Member
Author
There was a problem hiding this comment.
This PR mainly provides a demo to show the result and these logs are actually for debugging. And another clean PR focus on memory optimization transpiler #7356 has been merged.
So I will close this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes:
The cache memory pool can be hit:
Memory can be saved from 102400 bytes to 90112 bytes.
Memory use before optimization in a batch
Memory use after optimization in a batch