Skip to content

Rename CopyFrom to Copy for tensors#7292

Merged
tonyyang-svail merged 4 commits intoPaddlePaddle:developfrom
reyoung:feature/copy_from_to_copy
Jan 9, 2018
Merged

Rename CopyFrom to Copy for tensors#7292
tonyyang-svail merged 4 commits intoPaddlePaddle:developfrom
reyoung:feature/copy_from_to_copy

Conversation

@reyoung
Copy link
Collaborator

@reyoung reyoung commented Jan 8, 2018 •
edited
Loading

We have a global function named CopyFrom. It is a bad name.
Either dst.CopyFrom(src) or Copy(dst, src) is fine. Since we prefer to use global functions, just rename CopyFrom to Copy.
@reyoung reyoung requested a review from tonyyang-svail January 9, 2018 04:01
@reyoung reyoung changed the title Rename Tensor::CopyFrom to Tensor::Copy Jan 9, 2018
tonyyang-svail
tonyyang-svail approved these changes Jan 9, 2018
View reviewed changes
Copy link

@tonyyang-svail tonyyang-svail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@tonyyang-svail tonyyang-svail merged commit ce6dad3 into PaddlePaddle:develop Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@reyoung @tonyyang-svail