Merged
Conversation
luotao1
reviewed
Jan 4, 2018
| DEFINE_bool(use_mkl_packed, true, "Default use MKL Packed Optimization"); | ||
| #else | ||
| DEFINE_bool(use_mkl_packed, false, "Whether to use MKL Packed Optimization"); | ||
| #endif |
Contributor
There was a problem hiding this comment.
- 现在直接替换过早了，虽然单测过了，但是整体收敛效果如何还是要跑几个完整的例子来测下，类似v2和fluid的对比实验。how to add MKL Packed interface #6612 (comment) 这里说的test不仅仅是单测。
- false, "Whether to use MKL Packed Optimization"这里的注释对么？paddle_with_mklml没打开的时候，use_mkl_packed也不能用了吧。
Contributor
There was a problem hiding this comment.
最终是变成：
#ifdef PADDLE_WITH_MKLML
DEFINE_bool(use_mkl_packed, true, "whether to use MKL Packed Optimization, default true");
#else
DEFINE_bool(use_mkl_packed, false, "Not to use MKL Packed Optimization");
#endif
但由于现在default还不能开，可以改成：
DEFINE_bool(use_mkl_packed, false, "Whether to use MKL Packed Optimization");
这里可以加��个TODO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow #6612 about how to add MKL Packed interface