Remove the CUDA stream synchronization between each operator.#6284
Merged
qingqing01 merged 1 commit intoPaddlePaddle:developfrom Dec 5, 2017
Merged
Remove the CUDA stream synchronization between each operator.#6284qingqing01 merged 1 commit intoPaddlePaddle:developfrom
qingqing01 merged 1 commit intoPaddlePaddle:developfrom
Conversation
reyoung
approved these changes
Dec 5, 2017
Collaborator
reyoung
left a comment
reyoung
left a comment
There was a problem hiding this comment.
Cool. Should we remove DeviceContext::Finish?
Contributor
Author
I think this interface is convenient to debug, especially for the error check of CUDA kernel. |
Contributor
Author
|
I merge this PR, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6283
At first, we add this CUDA stream synchronization in the operator developing period to detect the CUDA error of each CUDA kernel. When the framework is stable, this synchronization should be removed to speed up training.