Skip to content

simplify the CMakeLists.txt of trainer/tests and gserver/tests#5830

Merged
luotao1 merged 8 commits intoPaddlePaddle:developfrom
luotao1:cmake
Dec 4, 2017
Merged

simplify the CMakeLists.txt of trainer/tests and gserver/tests#5830
luotao1 merged 8 commits intoPaddlePaddle:developfrom
luotao1:cmake

Conversation

@luotao1
Copy link
Contributor

@luotao1 luotao1 commented Nov 22, 2017

fix #5829

@luotao1 luotao1 requested review from Xreki and qingqing01 November 29, 2017 12:29
set(PYTHON_PATH
${PADDLE_SOURCE_DIR}/paddle/.set_python_path.sh -d
${PADDLE_SOURCE_DIR}/python/:${PADDLE_SOURCE_DIR}/paddle/gserver/tests)
function(gserver_test2 TARGET)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename gserver_test2 to gserver_test_with_python?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 09fc307 into PaddlePaddle:develop Dec 4, 2017
@luotao1 luotao1 deleted the cmake branch December 4, 2017 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants