Skip to content

Update annotations of layers.py#5487

Merged
lcy-seso merged 2 commits intoPaddlePaddle:developfrom
ranqiu92:doc
Nov 9, 2017
Merged

Update annotations of layers.py#5487
lcy-seso merged 2 commits intoPaddlePaddle:developfrom
ranqiu92:doc

Conversation

@ranqiu92
Copy link
Contributor

@ranqiu92 ranqiu92 commented Nov 8, 2017

@ranqiu92 ranqiu92 requested a review from lcy-seso November 8, 2017 11:06
lcy-seso
lcy-seso reviewed Nov 8, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
python/paddle/trainer_config_helpers/layers.py Outdated
for details.
:type inproj_param_attr: ParameterAttribute
:param inproj_bias_attr: The bias attribute of the projection. If the parameter is set to
False or something not type of ParameterAttribute, no bias is
Copy link
Contributor

@lcy-seso lcy-seso Nov 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把 "something not type of ParameterAttribute," 改为 If this parameter is set False or an object whose type is not ParameterAttribute 吧~ 原来那句话有语法错误。

其它出现地方相同。
Copy link
Contributor Author

@ranqiu92 ranqiu92 Nov 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
lcy-seso
lcy-seso reviewed Nov 9, 2017
View reviewed changes
python/paddle/trainer_config_helpers/layers.py Outdated
Copy link
Contributor

@lcy-seso lcy-seso Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a type: dimension.
Copy link
Contributor Author

@ranqiu92 ranqiu92 Nov 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
lcy-seso
lcy-seso previously approved these changes Nov 9, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thank you
lcy-seso
lcy-seso approved these changes Nov 9, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.
@lcy-seso lcy-seso merged commit b8e782c into PaddlePaddle:develop Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ranqiu92 @lcy-seso