deconv cudnn forward passed#5235
Merged
zchen0211 merged 22 commits intoPaddlePaddle:developfrom Nov 2, 2017
Merged
Conversation
* refine evaluator op types * update * follow comments * update * fix v2 mnist case * fix v2 mnist case * update * update
* "modify layers.py" * "fix pool interface" * "add export type to layers" * "fix based on comment"
* AddBiasOp does not care num_flatten_dims * Add comments
zchen0211
requested review from
chengduoZH,
dzhwinter,
jacquesqiao and
qingqing01
Contributor
|
You should remove uncorrelated commits. Maybe |
chengduoZH
reviewed
Nov 1, 2017
| } // namespace paddle | ||
|
|
||
| namespace ops = paddle::operators; | ||
| REGISTER_OP(conv2dtranspose_cudnn, ops::Conv2DTransposeOp, |
Contributor
There was a problem hiding this comment.
Is it appropriate that replacing conv2dtranspose_cudnn with conv2d_transpose_cudnn
Contributor
|
|
jacquesqiao
reviewed
Nov 1, 2017
| using DataLayout = platform::DataLayout; | ||
| using CUDADeviceContext = platform::CUDADeviceContext; | ||
|
|
||
| static constexpr size_t kCONV_CUDNN_WORKSPACE_LIMIT_BYTES = 1024 * 1024 * 1024; |
Member
There was a problem hiding this comment.
this not meed the google code style.
http://google.github.io/styleguide/cppguide.html#Constant_Names
jacquesqiao
reviewed
Nov 1, 2017
|
|
||
| std::vector<int> strides = ctx.Attr<std::vector<int>>("strides"); | ||
| std::vector<int> paddings = ctx.Attr<std::vector<int>>("paddings"); | ||
| std::vector<int> dilations = ctx.Attr<std::vector<int>>("dilations"); |
Member
There was a problem hiding this comment.
add a comment that cuDNN does not support dilations.
jacquesqiao
reviewed
Nov 1, 2017
|
|
||
| namespace ops = paddle::operators; | ||
|
|
||
| REGISTER_OP_GPU_KERNEL(conv2d_transpose_cudnn, |
Member
There was a problem hiding this comment.
why name it conv2d_transpose?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
working on backward now...