Add log to InitParam GetParameter SendGrad and etc.#5162
Merged
gongweibao merged 24 commits intoPaddlePaddle:developfrom Oct 31, 2017
Merged
Add log to InitParam GetParameter SendGrad and etc.#5162gongweibao merged 24 commits intoPaddlePaddle:developfrom
InitParam GetParameter SendGrad and etc.#5162gongweibao merged 24 commits intoPaddlePaddle:developfrom
Conversation
helinwang
reviewed
Oct 27, 2017
Contributor
helinwang
left a comment
helinwang
left a comment
There was a problem hiding this comment.
You are amazing! Very help changes for adding the proto and the pretty print. Thanks!
go/pserver/service.go
Outdated
| } | ||
|
|
||
| var s string | ||
| s = "top:" + float32ToString(a) |
Contributor
There was a problem hiding this comment.
Maybe don't need top: and tail, developer probably can understand [3.3702806e+12 2.142699] ... [3.3702806e+12 2.142699], would be better if we can remove ] and [: [3.3702806e+12 2.142699 ... 3.3702806e+12 2.142699]
go/pserver/service_test.go
Outdated
| wg.Wait() | ||
| } | ||
|
|
||
| func TestCheckpointSpeed(t *testing.T) { |
Contributor
There was a problem hiding this comment.
I know it's already there, could you remove this function?
Contributor
Author
There was a problem hiding this comment.
恩，我还以为这是一个TODO的内容。
Done。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5161