support sparse output for lookup table grad op#5145
Merged
QiJune merged 29 commits intoPaddlePaddle:developfrom Oct 28, 2017
Merged
support sparse output for lookup table grad op#5145QiJune merged 29 commits intoPaddlePaddle:developfrom
QiJune merged 29 commits intoPaddlePaddle:developfrom
Conversation
reyoung
approved these changes
Oct 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
is_sparseattribute for lookup table operator. And book04.word2vec can run in sparse update mode. But there is some memory error after some batches training. It can be generated stably after 21 batches. So, I will debug this to make sure sparse update is worked.Updated:
The bug has been found with the help of @reyoung . In Lookup Table Grad operator, there is a bug of array bounds.