Skip to content

enhance default param_attrs#5142

Merged
reyoung merged 1 commit intoPaddlePaddle:developfrom
reyoung:feature/enhance_param_attr
Oct 27, 2017
Merged

enhance default param_attrs#5142
reyoung merged 1 commit intoPaddlePaddle:developfrom
reyoung:feature/enhance_param_attr

Conversation

@reyoung
Copy link
Collaborator

@reyoung reyoung commented Oct 26, 2017

No description provided.

@reyoung reyoung force-pushed the feature/enhance_param_attr branch 2 times, most recently from 1a2cfd9 to 6e4bf3e Compare October 26, 2017 23:50
return actual

def bias_attr(self):
default = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about changing the type into init_method or another name.

Copy link
Member

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit 9596731 into PaddlePaddle:develop Oct 27, 2017
@reyoung reyoung deleted the feature/enhance_param_attr branch October 28, 2017 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants