Adding interface for the adagrad optimizer#4977
Merged
kexinzhao merged 2 commits intoPaddlePaddle:developfrom Oct 21, 2017
Merged
Adding interface for the adagrad optimizer#4977kexinzhao merged 2 commits intoPaddlePaddle:developfrom
kexinzhao merged 2 commits intoPaddlePaddle:developfrom
Conversation
abhinavarora
suggested changes
Oct 20, 2017
| """ | ||
| _moment_acc_str = "moment" | ||
|
|
||
| def __init__(self, learning_rate, epsilon): |
Contributor
There was a problem hiding this comment.
You can give a default value to the epsilon.
Contributor
There was a problem hiding this comment.
Also if the original paper mentions a default learning rate value for the Adagrad optimizer, then you can add it too.
Contributor
Author
There was a problem hiding this comment.
Done. The original paper does not specify a default learning rate. Only added default value to epsilon.
abhinavarora
approved these changes
Oct 21, 2017
Contributor
abhinavarora
left a comment
abhinavarora
left a comment
There was a problem hiding this comment.
LGTM. Thank you. The PR looks great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4916