Fix v2 optimizer define order#4972
Merged
typhoonzero merged 3 commits intoPaddlePaddle:developfrom Oct 23, 2017
Merged
Conversation
lcy-seso
reviewed
Oct 23, 2017
python/paddle/v2/topology.py
Outdated
| parameter.initial_smart = cp.g_default_initial_smart | ||
| if parameter.num_batches_regularization == 1 and cp.g_default_num_batches_regularization: | ||
| parameter.num_batches_regularization = cp.g_default_num_batches_regularization | ||
| if parameter.gradient_clipping_threshold == 0.0 and cp.g_default_gradient_clipping_threshold: |
python/paddle/v2/topology.py
Outdated
| # are defined after layers, or between layers. | ||
| # Must be called from trainer.__init__() | ||
| for parameter in self.__model_config__.parameters: | ||
| print "####", parameter.decay_rate, cp.g_default_decay_rate |
Contributor
There was a problem hiding this comment.
Is this print necessary? It seems that this is for debug print?
lcy-seso
reviewed
Oct 23, 2017
paddle/math/RowBuffer.h
Outdated
| CHECK_LE((row + 1) * width_ * sizeof(real), preallocatedBuf_->getSize()); | ||
| // CHECK_LE((row + 1) * width_ * sizeof(real), | ||
| // preallocatedBuf_->getSize()); | ||
| CHECK_LE((row)*width_ * sizeof(real), preallocatedBuf_->getSize()); |
Contributor
There was a problem hiding this comment.
I am not sure what are these lines for? are these lines accidentally added?
Contributor
Author
There was a problem hiding this comment.
Sorry, that's for my local testing, will revert this file.
lcy-seso
approved these changes
Oct 23, 2017
Contributor
lcy-seso
left a comment
lcy-seso
left a comment
There was a problem hiding this comment.
LGTM, thank you very much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2621
Fix #2563