Change PADDLE_ONLY_CPU to PADDLE_WITH_GPU#4584
Merged
wangkuiyi merged 1 commit intoPaddlePaddle:developfrom Oct 4, 2017
Merged
Change PADDLE_ONLY_CPU to PADDLE_WITH_GPU#4584wangkuiyi merged 1 commit intoPaddlePaddle:developfrom
PADDLE_ONLY_CPU to PADDLE_WITH_GPU#4584wangkuiyi merged 1 commit intoPaddlePaddle:developfrom
Conversation
Collaborator
|
Thanks for this PR! @reyoung I am afraid that this https://github.com/PaddlePaddle/Paddle/search?utf8=%E2%9C%93&q=PADDLE_ONLY_CPU&type= I see 82 C++ files, 2 CUDA files, and 1 C files, which sum up to 85 source files. However, this PR changes 84 files in total, including the configure.cmake file. |
Collaborator
|
I see. @reyoung you might forgot to update the two .cu files: https://github.com/PaddlePaddle/Paddle/search?l=Cuda&q=PADDLE_ONLY_CPU&type=&utf8=%E2%9C%93 In above command line, we need to add |
Collaborator
Author
Yes. I will add that soon. |
882fc4e to
84500f9
Compare
By shell command ```bash sed -i 's#ifdef PADDLE_ONLY_CPU#ifndef PADDLE_WITH_GPU#g' `find ./paddle/ -name '*.h' -o -name '*.cc' -o -name '*.cpp' -o -name '*.c' -o -name '*.cu'` sed -i 's#ifndef PADDLE_ONLY_CPU#ifdef PADDLE_WITH_GPU#g' `find ./paddle/ -name '*.h' -o -name '*.cc' -o -name '*.cpp' -o -name '*.c' -o -name '*.cu'` ```
wangkuiyi
approved these changes
Oct 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4588
By shell command