Merged
Conversation
reyoung
commented
Sep 30, 2017
| attr_desc->set_type( | ||
| static_cast<framework::AttrType>(attr.second.which() - 1)); | ||
| boost::apply_visitor(SetAttrDescVisitor(attr_desc), attr.second); | ||
| SetAttrDescVisitor visitor(attr_desc); |
Collaborator
Author
There was a problem hiding this comment.
This change is recommended by clang-tidy for code reading.
JiayiFeng
previously approved these changes
Oct 1, 2017
wangkuiyi
reviewed
Oct 4, 2017
| namespace framework { | ||
|
|
||
| // The order should be as same as framework.proto | ||
| typedef boost::variant<boost::blank, int, float, std::string, std::vector<int>, |
Collaborator
There was a problem hiding this comment.
What is the reason of moving type Attribute from attribute.h into a new header files type_defs.h? This PR claims to resolve a cyclic dependency issue, but there is no description of this issue.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.