Skip to content

Remove OperatorBase::InferShape#4458

Merged
reyoung merged 1 commit intoPaddlePaddle:developfrom
reyoung:feature/compile_time_infer_shape
Sep 28, 2017
Merged

Remove OperatorBase::InferShape#4458
reyoung merged 1 commit intoPaddlePaddle:developfrom
reyoung:feature/compile_time_infer_shape

Conversation

@reyoung
Copy link
Collaborator

@reyoung reyoung commented Sep 28, 2017

InferShape in Operator should be performed in OperatorBase::Run.

  • cond_op, recurrent_op and mnist might be changed in following PR
InferShape in Operator should be performed in OperatorBase::Run.

* cond_op, recurrent_op and mnist might be changed in following PR
@reyoung reyoung requested a review from jacquesqiao September 28, 2017 03:15
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit 21f63ec into PaddlePaddle:develop Sep 28, 2017
@reyoung reyoung deleted the feature/compile_time_infer_shape branch October 2, 2017 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants