"add name convention url"#4277
Merged
dzhwinter merged 2 commits intoPaddlePaddle:developfrom Sep 21, 2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
添加了命名规范文档。
另外,new_op_cn.md中OpProtoMaker的示例没有遵守命名规范。
其中参数注释有点太粗糙了,没有解释清楚参数。例如"The first input of mul op"没有解释任何事情, 改成 "(Tensor)2D tensor of size (M x K)"会好一些。
Input/Output的注释请尽量包括
命名规范中对comments的约束是
命名规范的示例