Do not invoke GPU method when use_gpu=false#4138
Merged
wangkuiyi merged 1 commit intoPaddlePaddle:developfrom Sep 16, 2017
Merged
Conversation
Superjomn
approved these changes
Sep 16, 2017
dzhwinter
reviewed
Sep 16, 2017
|
|
||
| { | ||
| AsyncGpuBlock asyncGpuBlock; | ||
| std::unique_ptr<AsyncGpuBlock> asyncBlock; |
Contributor
There was a problem hiding this comment.
seems no other place use this Block? ? ?.
I am really confusing about Paddle's init logic, almost a black box to me.
Collaborator
Author
There was a problem hiding this comment.
Well, that is very amazing C++ technic which called RAII.
It just creates some resource when the constructor is invoked, and release them when the deconstructor is invoked. It is something similar with with keyword in Python.
It is widely used in std library, such as unique_ptr, lock_guard, shared_ptr, etc.
More details, please refer that wiki page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.