Skip to content

fix the typo of the param description in sequence_conv_pool#4034

Merged
lcy-seso merged 12 commits intoPaddlePaddle:developfrom
peterzhang2029:my-paddle
Sep 17, 2017
Merged

fix the typo of the param description in sequence_conv_pool#4034
lcy-seso merged 12 commits intoPaddlePaddle:developfrom
peterzhang2029:my-paddle

Conversation

@peterzhang2029
Copy link
Contributor

@peterzhang2029 peterzhang2029 commented Sep 12, 2017

resolve #4033
@luotao1
Copy link
Contributor

luotao1 commented Sep 12, 2017

Please use pre-commit to pass the check-stype of travis-ci.
lcy-seso
lcy-seso reviewed Sep 16, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work, and please delete the unused comments.
python/paddle/trainer_config_helpers/networks.py

"""
# from activations import *
from activations import LinearActivation, ReluActivation, SoftmaxActivation, \
Copy link
Contributor

@lcy-seso lcy-seso Sep 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete line 14 ~ 17
lcy-seso
lcy-seso approved these changes Sep 17, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@lcy-seso lcy-seso merged commit 8c71e09 into PaddlePaddle:develop Sep 17, 2017
@peterzhang2029 peterzhang2029 deleted the my-paddle branch September 18, 2017 03:22
@peterzhang2029 peterzhang2029 restored the my-paddle branch September 18, 2017 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@peterzhang2029 @luotao1 @lcy-seso