Refactorization overview#3970
Merged
wangkuiyi merged 3 commits intoPaddlePaddle:developfrom Sep 19, 2017
Merged
Conversation
jacquesqiao
reviewed
Sep 8, 2017
| 1. create operators and set attributes, | ||
| 1. validate attribute values, | ||
| 1. inference the type and the shape of variables, | ||
| 1. plan for memory-reuse for variables, |
Member
There was a problem hiding this comment.
the order should be
1. generate backward and optimization part of the Graph
1. plan for memory-reuse for variables
memory-reuse should be done after the graph is completed.
jacquesqiao
reviewed
Sep 8, 2017
| - when graph executes, a Block with `BlockDesc` passed in creates `Op` and `Var` then `Run` | ||
|
|
||
| --- | ||
| # Milestone |
Member
There was a problem hiding this comment.
I think Milestone should be in another pr or issue because other parts of this PR is a summary of the refactorized Paddle. They are knowledge but not plan.
dzhwinter
reviewed
Sep 11, 2017
|
|
||
| 1. Users write Python programs to describe the graphs and run it (locally or remotely). | ||
|
|
||
| 1. A graph is composed of *variabels* and *operators*. |
| - accept imperfection, concentrated on solving the specific problem at the right price. | ||
|
|
||
| --- | ||
| # Control the migration quality |
Contributor
There was a problem hiding this comment.
- Milestone* and Control the migration quality is not part of refactorization overview structure, it's better to move them into the roadmap or sth like that.
jacquesqiao
approved these changes
Sep 19, 2017
Member
jacquesqiao
left a comment
jacquesqiao
left a comment
There was a problem hiding this comment.
This is a very good material to have an overview of PaddlePaddle refactor, we can merge it first and then optimize later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.