Skip to content

Add scale factor for smoothL1 and smoothL1Bp#2267

Merged
qingqing01 merged 1 commit intoPaddlePaddle:developfrom
pkuyym:fix-2265
Jun 2, 2017
Merged

Add scale factor for smoothL1 and smoothL1Bp#2267
qingqing01 merged 1 commit intoPaddlePaddle:developfrom
pkuyym:fix-2265

Conversation

@pkuyym
Copy link
Contributor

@pkuyym pkuyym commented May 25, 2017

fix #2265
@pkuyym pkuyym requested a review from qingqing01 May 25, 2017 04:31
luotao1
luotao1 reviewed May 25, 2017
View reviewed changes
paddle/math/Matrix.cpp Outdated
Copy link
Contributor

@luotao1 luotao1 May 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

cost[i] = destScale * cost[i]
if (absVal < 1.0)
  cost[i] += 0.5 * absVal * absVal;
else
  cost[i] += absVal - 0.5;

下面grad部分可以同样修改。
Copy link
Contributor Author

@pkuyym pkuyym May 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样确实简洁，done
Copy link
Contributor

@luotao1 luotao1 May 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果更简洁的话，可以写成：

 cost[i] += (absVal < 1.0) ?  0.5 * absVal * absVal : absVal - 0.5;
qingqing01
qingqing01 approved these changes Jun 2, 2017
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@qingqing01 qingqing01 merged commit 42f47d4 into PaddlePaddle:develop Jun 2, 2017
@pkuyym pkuyym deleted the fix-2265 branch July 6, 2017 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@pkuyym @luotao1 @qingqing01