Conversation
Dockerfile.android
Outdated
| # Fix locales to en_US.UTF-8 | ||
| RUN localedef -i en_US -f UTF-8 en_US.UTF-8 | ||
|
|
||
| RUN curl -sSL https://cmake.org/files/v3.2/cmake-3.2.2.tar.gz | tar -xz && \ |
There was a problem hiding this comment.
I noticed that the base image is Ubuntu 16.04. I think we can use apt to install a recent enough version of cmake, like we did in the main Dockerfile.
| const int lda, | ||
| const int* ipiv) { | ||
| return dynload::PADDLE_DGETRI(order, N, A, lda, ipiv); | ||
| return 0; |
There was a problem hiding this comment.
I am far from an expert of the math package. Just curious if this change is related to Android?
There was a problem hiding this comment.
It is not related to Android. I found this redundant statement accidentally when I was doing this work. Should I do this change in another pull request?
There was a problem hiding this comment.
Yeah. I agree with you that separation is a good idea, because this change requires a different group of reviewers, who are supposed to be familiar with math code, other than Android building.
But if you are sure this change is correct, I don't insist that we must separate it from this PR into a new PR. You are welcome to make the decision. :-)
There was a problem hiding this comment.
Thank you, :). I think it is just a typo. I will ask @gangliao to check it.
| @@ -0,0 +1,42 @@ | |||
| FROM ubuntu:16.04 | |||
| MAINTAINER PaddlePaddle Authors <paddle-dev@baidu.com> | |||
There was a problem hiding this comment.
Can we add this into Travis CI or TeamCity now?
There was a problem hiding this comment.
Do we need to discuss it?
3 participants
Use the following command to build the developing image and cross-compile Paddle: