Skip to content

add assert when is_seq=True, there must be a bootLayer in the network#2161

Merged
lcy-seso merged 2 commits intoPaddlePaddle:developfrom
luotao1:memory
May 17, 2017
Merged

add assert when is_seq=True, there must be a bootLayer in the network#2161
lcy-seso merged 2 commits intoPaddlePaddle:developfrom
luotao1:memory

Conversation

@luotao1
Copy link
Contributor

@luotao1 luotao1 commented May 16, 2017

fix #2142

@luotao1 luotao1 requested review from lcy-seso and xinghai-sun May 16, 2017 08:42
@wangkuiyi wangkuiyi changed the title add assert when is_seq=True, there must be bootLayer May 16, 2017
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small modification.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是可以直接改在 config_parser.py里面,这样不论是使用v0,v1,v2的用户都能报错误。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcy-seso lcy-seso merged commit 39b9112 into PaddlePaddle:develop May 17, 2017
@luotao1 luotao1 deleted the memory branch June 5, 2017 04:33
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants