Skip to content

Add Google style conventions in Majel#2126

Merged
gangliao merged 1 commit intoPaddlePaddle:developfrom
gangliao:new_tensor
May 13, 2017
Merged

Add Google style conventions in Majel#2126
gangliao merged 1 commit intoPaddlePaddle:developfrom
gangliao:new_tensor

Conversation

@gangliao
Copy link
Contributor

@gangliao gangliao commented May 13, 2017

fix #2124 #2125

@gangliao gangliao requested review from helinwang and wangkuiyi May 13, 2017 03:01
- python2.7-dev
- python-numpy
- python-wheel
- libboost-dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable majel test in travis ci

target_link_libraries(majel_tests
${Boost_LIBRARIES}
${GTEST_LIBRARIES}
${GTEST_MAIN_LIBRARIES}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add gtest_main lib.

Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@gangliao gangliao merged commit ecae6e6 into PaddlePaddle:develop May 13, 2017
fsylmxx pushed a commit to fsylmxx/Paddle that referenced this pull request Nov 25, 2025
Co-authored-by: Yuqiang Ge <143453447+YqGe585@users.noreply.github.com>
Co-authored-by: Tao Luo <luotao02@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants