Skip to content

SSA Graph Builder Factory#11234

Merged
reyoung merged 1 commit intoPaddlePaddle:developfrom
reyoung:feature/refine_code
Jun 7, 2018
Merged

SSA Graph Builder Factory#11234
reyoung merged 1 commit intoPaddlePaddle:developfrom
reyoung:feature/refine_code

Conversation

@reyoung
Copy link
Collaborator

@reyoung reyoung commented Jun 6, 2018

  • Use Builder Chain to decorate new builders. It is easy to extend
    builders.
  • Make graphviz path as a build strategy, not a FLAGS.
@reyoung reyoung force-pushed the feature/refine_code branch from 9770273 to 7521520 Compare June 6, 2018 08:40
@reyoung reyoung requested a review from chengduoZH June 6, 2018 08:41
* Use Builder Chain to decorate new builders. It is easy to extend
  builders.
* Make graphviz path as a build strategy, not a FLAGS.
@reyoung reyoung force-pushed the feature/refine_code branch from 7521520 to d9af153 Compare June 6, 2018 12:36
Copy link
Contributor

@chengduoZH chengduoZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit ff9b1a0 into PaddlePaddle:develop Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants