make benchmark really working#11215
Merged
gongweibao merged 4 commits intoPaddlePaddle:developfrom Jun 7, 2018
Merged
Conversation
gongweibao
requested changes
Jun 6, 2018
Contributor
gongweibao
left a comment
gongweibao
left a comment
There was a problem hiding this comment.
If we have run_fluid_benchmark.sh, do we need the run step in README.md?
| You can choose to use GPU/CPU training. With GPU training, you can specify | ||
| `--gpus <gpu_num>` to run multi GPU training. | ||
| * Run distributed training with parameter servers: | ||
| * see run_fluid_benchmark.sh as an example. |
Contributor
Author
There was a problem hiding this comment.
Not sure this is needed. link can be broken and the file is just in this folder
Contributor
There was a problem hiding this comment.
[run_fluid_benchmark.sh](./run_fluid_benchmark.sh)
| * see run_fluid_benchmark.sh as an example. | ||
| * start parameter servers: | ||
| ```bash | ||
| PADDLE_TRAINING_ROLE=PSERVER PADDLE_PSERVER_PORT=7164 PADDLE_PSERVER_IPS=127.0.0.1 PADDLE_TRAINERS=1 PADDLE_CURRENT_IP=127.0.0.1 PADDLE_TRAINER_ID=0 python fluid_benchmark.py --model mnist --device GPU --update_method pserver |
Yancey0623
reviewed
Jun 6, 2018
| @@ -0,0 +1,10 @@ | |||
| #!/bin/bash | |||
|
|
|||
| PADDLE_TRAINING_ROLE=PSERVER PADDLE_PSERVER_PORT=7164 PADDLE_PSERVER_IPS=127.0.0.1 PADDLE_TRAINERS=2 PADDLE_CURRENT_IP=127.0.0.1 PADDLE_TRAINER_ID=0 python fluid_benchmark.py --model resnet --device GPU --update_method pserver --iterations=10000 & | |||
Contributor
There was a problem hiding this comment.
Seems this command would print all logs on the terminal, we can startup them as follows:
PADDLE_TRAINING_ROLE=PSERVER ... stdbuf -oL nohup python fluid_benchmark.py <args> 2>&1 > server.log &And then users would check the logs in the server.log file.
Contributor
Author
There was a problem hiding this comment.
I think it's fine to print out some logs to give user some feedback. There aren't many outputs
Pass 0, batch 162, loss [2.7855887 2.973915 ]
Pass 0, batch 162, loss [3.0754983 3.2426462]
Pass 0, batch 171, loss [3.4701207 4.438573 ]
Pass 0, batch 171, loss [3.7791452 3.3191109]
typhoonzero
previously approved these changes
Jun 6, 2018
gongweibao
previously approved these changes
Jun 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user complain they crash when following our doc.