fix protobuf memory leak#11177
Merged
jacquesqiao merged 4 commits intoPaddlePaddle:developfrom Jun 5, 2018
Merged
Conversation
panyx0718
approved these changes
Jun 5, 2018
jacquesqiao
added a commit
to jacquesqiao/Paddle
that referenced
this pull request
Jun 5, 2018
fix protobuf memory leak
panyx0718
added a commit
that referenced
this pull request
Jun 5, 2018
…k-to-0.13.0 fix protobuf memory leak (#11177)
xinyu009
added a commit
that referenced
this pull request
Oct 12, 2019
* disable nccl test * Update version. * fix term core only * fix transpiler error * fix protobuf memory leak (#11177) fix protobuf memory leak * "change eigen mirror" * refine en doc sequence enum pad expand mask d2s * refine seq enum expand mask pad test=develop, test=document_fix * remove cn char test=document_fix * spec test=document_fix * code style test=document_fix * test=document_fix * test=document_fix * test=document_fix * test=document_fix * test=document_fix * test=document_fix
xinyu009
added a commit
to xinyu009/Paddle
that referenced
this pull request
Oct 12, 2019
* disable nccl test * Update version. * fix term core only * fix transpiler error * fix protobuf memory leak (PaddlePaddle#11177) fix protobuf memory leak * "change eigen mirror" * refine en doc sequence enum pad expand mask d2s * refine seq enum expand mask pad test=develop, test=document_fix * remove cn char test=document_fix * spec test=document_fix * code style test=document_fix * test=document_fix * test=document_fix * test=document_fix * test=document_fix * test=document_fix * test=document_fix
xinyu009
added a commit
that referenced
this pull request
Oct 15, 2019
* disable nccl test * Update version. * fix term core only * fix transpiler error * fix protobuf memory leak (#11177) fix protobuf memory leak * "change eigen mirror" * test=document_fix * test=document_fix
seiriosPlus
pushed a commit
to seiriosPlus/Paddle
that referenced
this pull request
Dec 9, 2019
* disable nccl test * Update version. * fix term core only * fix transpiler error * fix protobuf memory leak (PaddlePaddle#11177) fix protobuf memory leak * "change eigen mirror" * refine en doc sequence enum pad expand mask d2s * refine seq enum expand mask pad test=develop, test=document_fix * remove cn char test=document_fix * spec test=document_fix * code style test=document_fix * test=document_fix * test=document_fix * test=document_fix * test=document_fix * test=document_fix * test=document_fix
seiriosPlus
pushed a commit
to seiriosPlus/Paddle
that referenced
this pull request
Dec 9, 2019
* disable nccl test * Update version. * fix term core only * fix transpiler error * fix protobuf memory leak (PaddlePaddle#11177) fix protobuf memory leak * "change eigen mirror" * refine en doc sequence enum pad expand mask d2s * refine seq enum expand mask pad test=develop, test=document_fix * remove cn char test=document_fix * spec test=document_fix * code style test=document_fix * test=document_fix * test=document_fix * test=document_fix * test=document_fix * test=document_fix * test=document_fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #11100
according to https://developers.google.com/protocol-buffers/docs/reference/arenas
ReleaseLast
SubMessageType* ReleaseLast(): Returns a heap-allocated message equivalent to the last message in the repeated field, removing it from the repeated field. If the repeated field itself has a NULL arena pointer (and thus, all of its pointed-to messages are heap-allocated), then this method simply returns a pointer to the original object. Otherwise, if the repeated field has a non-NULL arena pointer, this method makes a copy that is heap-allocated and returns that copy. In both cases, the caller receives ownership of a heap-allocated object and is responsible for deleting the object.
analyse
If the message is allocated in arena memory pool, this function will make a copy on heap and return the pointer, but no one will delete the pointer in our code.