Modify optimizer in new API to support more usecases#11168
Merged
sidgoyal78 merged 2 commits intoPaddlePaddle:developfrom Jun 4, 2018
Merged
Modify optimizer in new API to support more usecases#11168sidgoyal78 merged 2 commits intoPaddlePaddle:developfrom
sidgoyal78 merged 2 commits intoPaddlePaddle:developfrom
Conversation
jetfuel
approved these changes
Jun 4, 2018
This was referenced Jun 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11157
This PR implements the approach suggested by @jacquesqiao
This modifies the trainer and 2 examples:
In addition to @seiriosPlus 's observation, I observed similar issue while implementing the Label semantic roles example. This PR includes the earlier example from label semantic roles, and it is working with the new fix.