Skip to content

Add default prior box var for box_coder_op#11164

Merged
qingqing01 merged 5 commits intoPaddlePaddle:developfrom
Noplz:faster_rcnn
Jun 5, 2018
Merged

Add default prior box var for box_coder_op#11164
qingqing01 merged 5 commits intoPaddlePaddle:developfrom
Noplz:faster_rcnn

Conversation

@Noplz
Copy link
Contributor

@Noplz Noplz commented Jun 4, 2018

fix #10462

@qingqing01 qingqing01 requested review from kuke and qingqing01 June 5, 2018 02:08
@qingqing01 qingqing01 changed the title add default prior box var Jun 5, 2018
prior_box_var_data = default_box_var.data<T>();
} else {
prior_box_var_data = prior_box_var->data<T>();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make EncodeCenterSizeKernel and DecodeCenterSizeKernel to support whether to consider the variance, instead of creating a constant Tensor with all 1 here.

Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qingqing01 qingqing01 merged commit 666c94e into PaddlePaddle:develop Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants