Skip to content

fix build error on mac#11134

Merged
jacquesqiao merged 2 commits intoPaddlePaddle:developfrom
jacquesqiao:fix-mac-build
Jun 4, 2018
Merged

fix build error on mac#11134
jacquesqiao merged 2 commits intoPaddlePaddle:developfrom
jacquesqiao:fix-mac-build

Conversation

@jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Jun 3, 2018 

/Users/qiaolongfei/project/paddle/paddle/fluid/operators/detail/grpc_server.h:75:15: error: private field 'barrier_cond_step_' is not used [-Werror,-Wunused-private-field]
  mutable int barrier_cond_step_;

/Users/qiaolongfei/project/paddle/paddle/fluid/operators/listen_and_serv_op.cc:225:29: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
  h->SetPrefetchPreparedCtx(std::move(
                            ^
/Users/qiaolongfei/project/paddle/paddle/fluid/operators/listen_and_serv_op.cc:225:29: note: remove std::move call here
  h->SetPrefetchPreparedCtx(std::move(
                            ^~~~~~~~~~
gongweibao
gongweibao requested changes Jun 3, 2018
View reviewed changes
Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!
paddle/fluid/operators/detail/grpc_server.h Outdated
// condition of the sub program
std::mutex barrier_mutex_;
mutable int barrier_cond_step_;
// std::mutex barrier_mutex_;
Copy link
Contributor

@gongweibao gongweibao Jun 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be deleted.
gongweibao
gongweibao approved these changes Jun 4, 2018
View reviewed changes
Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jacquesqiao jacquesqiao merged commit c7002f5 into PaddlePaddle:develop Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jacquesqiao @gongweibao