inference API little fix#11069
Merged
Superjomn merged 9 commits intoPaddlePaddle:developfrom May 31, 2018
Merged
Conversation
luotao1
reviewed
May 31, 2018
| get_property(fluid_modules GLOBAL PROPERTY FLUID_MODULES) | ||
| cc_library(paddle_fluid DEPS ${fluid_modules}) | ||
|
|
||
| if(WITH_CONTRIB) |
Contributor
There was a problem hiding this comment.
这样写，有点多，能不能改成：
if(WITH_CONTRIB)
set(fluid_modules ${fluid_modules} paddle_inference_api)
endif()
后面就可以保持不变了。
Superjomn
force-pushed
the
feature/inference_api_fix
branch
from
c92481b to
1463aca
Compare
panyx0718
previously approved these changes
May 31, 2018
| * non-sequence scenerios. | ||
| * TODO(Superjomn) Prepare another API for NLP-related usages. | ||
| */ | ||
| * A simple Inference API for Paddle. Currently this API might just be used by |
| */ | ||
| * A simple Inference API for Paddle. Currently this API might just be used by | ||
| * non-sequence scenerios. | ||
| * TODO(Superjomn) Prepare another API for NLP-related usages. |
Contributor
There was a problem hiding this comment.
" Prepare another API for" -> "Support"
panyx0718
approved these changes
May 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.