Fix compile error on mac caused by std move#11034
Merged
jacquesqiao merged 8 commits intoPaddlePaddle:developfrom May 31, 2018
Merged
Fix compile error on mac caused by std move#11034jacquesqiao merged 8 commits intoPaddlePaddle:developfrom
jacquesqiao merged 8 commits intoPaddlePaddle:developfrom
Conversation
Superjomn
reviewed
May 30, 2018
|
|
||
| std::unique_ptr<PaddlePredictor> PaddlePredictorImpl::Clone() { | ||
| VLOG(3) << "Predictor::clone"; | ||
| std::unique_ptr<PaddlePredictor> cls(new PaddlePredictorImpl(config_)); |
Contributor
There was a problem hiding this comment.
this will make mac success but make manylinux fail.
try return pointer, that mac works and might make manylinux success.
Member
Author
There was a problem hiding this comment.
There are many codes in fluid return a unique_ptr without the problem. Not sure why this place face problem on manylinux build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #11032
it's strange why CreatePaddlePredictorImpl do not have the same problem on manylinux
Paddle/paddle/contrib/inference/paddle_inference_api_impl.cc
Lines 287 to 308 in 654f5d3