Skip to content

add mkldnn to paddle lib#10705

Merged
jacquesqiao merged 5 commits intoPaddlePaddle:developfrom
jacquesqiao:add-mkldnn-to-paddle-lib
May 17, 2018
Merged

add mkldnn to paddle lib#10705
jacquesqiao merged 5 commits intoPaddlePaddle:developfrom
jacquesqiao:add-mkldnn-to-paddle-lib

Conversation

@jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented May 16, 2018

task list: #10574

@jacquesqiao jacquesqiao requested a review from luotao1 May 16, 2018 10:58
@Xreki Xreki added the 预测 原名Inference,包含Capi预测问题等 label May 16, 2018
copy(mkldnn_lib
SRCS ${MKLDNN_INSTALL_DIR}
DSTS ${dst_dir}
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前打包效果如下:

mkldnn/
├── include
│   ├── mkldnn_debug.h
│   ├── mkldnn.h
│   ├── mkldnn.hpp
│   └── mkldnn_types.h
├── lib
│   ├── libmkldnn.so -> libmkldnn.so.0
│   ├── libmkldnn.so.0 -> libmkldnn.so.0.14.0
│   └── libmkldnn.so.0.14.0
├── libmkldnn.so.0
└── share
    └── doc
        └── mkldnn
            └── LICENSE

可以精简下:

  • 去掉share目录
  • lib目录下只保留libmkldnn.so.0
mkldnn/
├── include
│   ├── mkldnn_debug.h
│   ├── mkldnn.h
│   ├── mkldnn.hpp
│   └── mkldnn_types.h
└── lib
    └── libmkldnn.so.0

可以试下:

SRCS ${MKLDNN_INC_DIR} ${MKLDNN_SHARED_LIB} 
DSTS ${dst} ${dst_dir}/lib
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

set(dst_dir "${CMAKE_INSTALL_PREFIX}/third_party/install/mkldnn")
copy(mkldnn_lib
SRCS ${MKLDNN_INC_DIR} ${MKLDNN_SHARED_LIB}
DSTS ${dst} ${dst_dir}/lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

105行第一个${dst}改成${dst_dir}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@luotao1 luotao1 added the Intel label May 17, 2018
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacquesqiao jacquesqiao merged commit ca0dce7 into PaddlePaddle:develop May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Intel 预测 原名Inference,包含Capi预测问题等

3 participants