Closed
Conversation
typhoonzero
reviewed
May 15, 2018
| void Executor::RunPreparedContext(ExecutorPrepareContext* ctx, Scope* scope, | ||
| bool create_local_scope, bool create_vars) { | ||
| bool create_local_scope, bool create_vars, | ||
| bool drop_scope_kids) { |
Contributor
There was a problem hiding this comment.
It's not a good way to add a bool switch here. I think a better way is to let listen_and_serv_op use a child scope.
Contributor
There was a problem hiding this comment.
I'll try remove the create_vars bool in executor to see if we can solve this
Contributor
Author
There was a problem hiding this comment.
Agree with using a sub-scope in listen_and_serv_op.
|
Since you haven't replied for a long time, we have closed this issue/pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #10625