Merged
Conversation
wangkuiyi
reviewed
May 7, 2018
python/paddle/fluid/executor.py
Outdated
|
|
||
| if not isinstance(program, Program): | ||
| raise TypeError() | ||
| raise TypeError("executor take Program as arguments.") |
Collaborator
There was a problem hiding this comment.
I don't quite understand this message -- should an executor take a Program instance as its argument or not? If the answer is yes, this message should be
An executor requires Program as its parameter, but we passed in ...
If the answer is no, the message should be
An executor doesn't accept Program as its parameter. Please pass in ...
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing this out. fixed.
sidgoyal78
approved these changes
May 10, 2018
Contributor
sidgoyal78
left a comment
sidgoyal78
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks good to me. The main idea is to infer the data type of the learning rate in the optimizer using the data type in loss.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add float64 tests