fixing #31, adding move with new alloc ctor #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

thirtytwobits merged 2 commits into main from feature/vla-move-w-alloc

Jun 20, 2023

Member

thirtytwobits commented Jun 11, 2023

No description provided.


          fixing #31, adding move with new alloc ctor

a8b1a4c

thirtytwobits commented

View reviewed changes

include/cetl/variable_length_array.hpp

                              std::allocator_traits<std::remove_reference_t<UAlloc>>::is_always_equal::value)>
                   {};
-                  // +----------------------------------------------------------------------+

Member Author

thirtytwobits Jun 11, 2023

This never ended up getting used so it was dead code.

thirtytwobits commented

View reviewed changes

include/cetl/variable_length_array.hpp

                   ///
                   using size_type = std::size_t;
-                  constexpr VariableLengthArrayBase(

Member Author

thirtytwobits Jun 11, 2023

I had to move this stuff down so it could use some of the functions defined below.

thirtytwobits commented

View reviewed changes

include/cetl/variable_length_array.hpp

    
                      UAlloc&& rhs,

                      typename std::enable_if<std::allocator_traits<

                          std::remove_reference_t<UAlloc>>::propagate_on_container_move_assignment::value>::type* =

                      typename std::enable_if_t<

Member Author

thirtytwobits Jun 11, 2023

The changes to enable_if_t was recommended by sonar qube.


          formatting fixes

8bd4a3a

sonarqubecloud bot commented Jun 11, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

98.5% Coverage
0.0% Duplication

thirtytwobits requested review from pavel-kirienko and skeetsaz

June 11, 2023 06:41

skeetsaz reviewed

View reviewed changes

include/cetl/variable_length_array.hpp Show resolved Hide resolved

skeetsaz approved these changes

View reviewed changes

thirtytwobits merged commit 3c6718a into main

thirtytwobits deleted the feature/vla-move-w-alloc branch

June 20, 2023 21:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment