Skip to content

Conversation

@abrichr
Copy link
Member

@abrichr abrichr commented Nov 12, 2024

No description provided.


yolo_model = get_yolo_model(model_path='weights/icon_detect/best.pt')
caption_model_processor = get_caption_model_processor(model_name="florence2", model_name_or_path="weights/icon_caption_florence")
# caption_model_processor = get_caption_model_processor(model_name="blip2", model_name_or_path="weights/icon_caption_blip2")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What're your thoughts on whether keeping it or reverting?

bb = [get_xyxy(item) for item in coord]
# print('bounding box!!!', bb)
return (text, bb), is_goal_filtered
return (text, bb), goal_filtering

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the initial purpose of is_goal_filtered?

) -> Tuple[Optional[Image.Image], Text]:
iou_threshold,
use_paddleocr
) -> Optional[Image.Image]:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tuple[Optional[Image.Image], Text]: looks more correct

@abrichr
Copy link
Member Author

abrichr commented Jan 20, 2025

Thanks @n-sviridenko ! The latest version of this PR is available at microsoft#52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants