Implement batched logging with auto flush#713
Merged
Conversation
Olical
commented
Oct 3, 2025
| (dyn.bind opts f (unpack args) ...) | ||
| (dyn.bind opts f ...))))) | ||
| (if (not= 0 (core.count args)) | ||
| (dyn.bind opts f (unpack (core.concat args [...]))) |
Owner
Author
There was a problem hiding this comment.
The linter was complaining saying only the first value from args would be used in the original code. So this change should fix that subtle bug and mean that it uses all of the args now. Unsure though! I'll write a test.
Owner
Author
There was a problem hiding this comment.
Yep! This was a bug, fixed.
Owner
Author
|
Also updated the extract tests so they work with the new and old tree sitter branches. |
…function that the linter was warning me about
a5c49bc to
5902386
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#689
Before
After
Issues
sandbox.cljcfile the line ofxxxxxxxxxxxxxxxxxxxxxdon't print as expected. It should be two lines of; (out)comments withxxxxxxxxxxxxxxxxxx- instead I'm seeing 3 lines, one of which has no; (out)prefix. When running one print at a time I see the; (out)on the same line as the; eval (root-form).