Skip to content

Add client-name to clone op#659

Merged
Olical merged 1 commit intoOlical:mainfrom
ericdallo:add-client-name-to-clone
Apr 19, 2025
Merged

Add client-name to clone op#659
Olical merged 1 commit intoOlical:mainfrom
ericdallo:add-client-name-to-clone

Conversation

@ericdallo
Copy link
Contributor

As discussed here, we are adding nREPL client information to be able to provide metrics about the client of the nREPL.

Related to nrepl/nrepl#370

@ericdallo ericdallo marked this pull request as ready for review April 9, 2025 16:10
@Olical
Copy link
Owner

Olical commented Apr 19, 2025

LGTM, I compiled this and tried it locally and I saw this across the wire / bencode.

{:client-name "Conjure" :id "c4418f24-b306-468e-bfd7-63819fdac59f" :op "clone"}

Thanks!

@Olical Olical merged commit 19b5691 into Olical:main Apr 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants