Convert uuid.fnl and add test#596
Merged
Olical merged 2 commits intoOlical:nfnl-migrationfrom Aug 21, 2024
russtoku:nfnl-migration
Merged
Convert uuid.fnl and add test#596Olical merged 2 commits intoOlical:nfnl-migrationfrom russtoku:nfnl-migration
Olical merged 2 commits intoOlical:nfnl-migrationfrom
russtoku:nfnl-migration
Conversation
Olical
approved these changes
Aug 21, 2024
Owner
Olical
left a comment
Olical
left a comment
There was a problem hiding this comment.
Making that public seems fine to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are commented functions at the bottom of uuid.fnl and are useful when using Conjure for development.
To make things externally tesable, I exported the formerly private cats-and-dogs list to use in a busted test to verify that
v4returns something in that list. I'm not sure if it's a good idea so if you think that we want to keep the cats-and-dogs private, I'm OK with that.