Merged
Conversation
Olical
approved these changes
Mar 11, 2024
Owner
Olical
left a comment
Olical
left a comment
There was a problem hiding this comment.
Thanks! This looks like a good fix. I would use a when instead of an if when it's a single branch though, I'll correct that post-merge happily because this is still fine Fennel, just would fail linting if such linting existed. (maybe it does!)
Contributor
Author
|
You're right. Force of habit lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc-str would silently fail and not display anything in nvim when used with Guile due to a missing check on the optional opts.on-result property. This PR fixes it