[18.0][MIG] web_widget_remaining_days_exact_date: Migration to 18.0 #3375

CILC98 · 2025-11-29T18:17:32Z

No description provided.

…date when remaining days shown This module is adding an option to the remaining_days widget to be able to show the exact date.

celm1990

Code review: I think it is necessary to split the commits. Please keep a single commit with only the changes related to the migration. If you want to improve this module, I think it is better to create a new PR with the new features, or at least put them in a separate commit and not in the migration commit.
What do you think, @CarlosRoca13 ?

celm1990 · 2025-12-17T20:53:50Z

web_widget_remaining_days_exact_date/__manifest__.py

@@ -0,0 +1,26 @@
+# Copyright 2025 Tecnativa - Carlos Roca Trescloud - César León


Suggested change

# Copyright 2025 Tecnativa - Carlos Roca Trescloud - César León

# Copyright 2025 Tecnativa - Carlos Roca

# Copyright 2025 Trescloud - César León

celm1990 · 2025-12-17T20:55:14Z

web_widget_remaining_days_exact_date/models/disable_remaining_days_rule.py

+                raise models.ValidationError(
+                    _(
+                        "There is already a rule for the model '%s'."
+                        " You cannot create two rules for the same model."
+                    )
+                    % record.res_model_id.name
+                )


Suggested change

raise models.ValidationError(

_(

"There is already a rule for the model '%s'."

" You cannot create two rules for the same model."

)

% record.res_model_id.name

)

raise models.ValidationError(

self.env._(

"There is already a rule for the model '%s'."

" You cannot create two rules for the same model.",

record.res_model_id.name

)

)

celm1990 · 2025-12-17T20:55:54Z

web_widget_remaining_days_exact_date/models/disable_remaining_days_rule.py

+                    "line_ids": [
+                        (
+                            0,
+                            0,
+                            {
+                                "name": name,
+                                "technical_name": technical_name,
+                                "active": active,
+                            },
+                        )
+                        for name, technical_name, active in view_types
+                    ],


Suggested change

"line_ids": [

(

0,

0,

{

"name": name,

"technical_name": technical_name,

"active": active,

},

)

for name, technical_name, active in view_types

],

"line_ids": [

Command.create(

{

"name": name,

"technical_name": technical_name,

"active": active,

},

)

for name, technical_name, active in view_types

],

celm1990 · 2025-12-17T21:00:40Z

web_widget_remaining_days_exact_date/models/disable_remaining_days_rule.py

Please follow the OCA guidelines. The order of fields, CRUD methods, etc. is described here:
https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#37models

celm1990 · 2025-12-17T21:02:08Z

web_widget_remaining_days_exact_date/tests/test_main.py

+
+
+@tagged("post_install", "-at_install")
+class TestWidgetRemainingDaysExactDate(common.TransactionCase):


Please inherit from BaseCommon

Suggested change

class TestWidgetRemainingDaysExactDate(common.TransactionCase):

class TestWidgetRemainingDaysExactDate(BaseCommon):

celm1990 · 2025-12-17T21:02:20Z

web_widget_remaining_days_exact_date/tests/test_main.py

+    @classmethod
+    def setUpClass(cls):
+        return super().setUpClass()


If this function does nothing, please remove it. Otherwise, implement the logic here to prepare the data for the test.

Suggested change

@classmethod

def setUpClass(cls):

return super().setUpClass()

celm1990 · 2025-12-17T21:05:27Z

web_widget_remaining_days_exact_date/views/disable_remaining_days_rule_views.xml

+                create="true"
+                edit="true"
+                delete="true"


These options are the default values, so it is not necessary to set them.

Suggested change

create="true"

edit="true"

delete="true"

celm1990 · 2025-12-17T21:06:13Z

web_widget_remaining_days_exact_date/static/src/widgets/remaining_days_fields.esm.js

@@ -0,0 +1,49 @@
+/** @odoo-module **/


Suggested change

/** @odoo-module **/

celm1990 · 2025-12-17T21:07:24Z

web_widget_remaining_days_exact_date/wizards/disable_remaining_days_rule_line_wizard.py

+    active = fields.Boolean(
+        string="Active record",
+    )


I don’t see the point of having an active field in a TransientModel. Why do you need this field? I think it can be removed.

Suggested change

active = fields.Boolean(

string="Active record",

)

CarlosRoca13 and others added 4 commits November 29, 2025 12:55

[ADD] web_widget_remaining_days_exact_date: New module to show exact …

a162dc4

…date when remaining days shown This module is adding an option to the remaining_days widget to be able to show the exact date.

[UPD] Update web_widget_remaining_days_exact_date.pot

de43bdd

Added translation using Weblate (Italian)

7af820c

[IMP] web_widget_remaining_days_exact_date: pre-commit auto fixes

16ed186

CILC98 force-pushed the 18.0-mig-web_widget_remaining_days_exact_date branch 2 times, most recently from cb57ded to b17d68c Compare November 29, 2025 19:26

[MIG] web_widget_remaining_days_exact_date: Migration to 18.0

4c54e3f

CILC98 force-pushed the 18.0-mig-web_widget_remaining_days_exact_date branch from b17d68c to 4c54e3f Compare November 30, 2025 00:30

celm1990 suggested changes Dec 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[18.0][MIG] web_widget_remaining_days_exact_date: Migration to 18.0 #3375

[18.0][MIG] web_widget_remaining_days_exact_date: Migration to 18.0 #3375

CILC98 commented Nov 29, 2025

celm1990 left a comment

celm1990 Dec 17, 2025

celm1990 Dec 17, 2025

celm1990 Dec 17, 2025

celm1990 Dec 17, 2025

celm1990 Dec 17, 2025

celm1990 Dec 17, 2025

celm1990 Dec 17, 2025

celm1990 Dec 17, 2025

celm1990 Dec 17, 2025

Labels

4 participants

		@@ -0,0 +1,26 @@
		# Copyright 2025 Tecnativa - Carlos Roca Trescloud - César León

	# Copyright 2025 Tecnativa - Carlos Roca Trescloud - César León
	# Copyright 2025 Tecnativa - Carlos Roca
	# Copyright 2025 Trescloud - César León



		@tagged("post_install", "-at_install")
		class TestWidgetRemainingDaysExactDate(common.TransactionCase):

	class TestWidgetRemainingDaysExactDate(common.TransactionCase):
	class TestWidgetRemainingDaysExactDate(BaseCommon):

Uh oh!

[18.0][MIG] web_widget_remaining_days_exact_date: Migration to 18.0 #3375

Are you sure you want to change the base?

[18.0][MIG] web_widget_remaining_days_exact_date: Migration to 18.0 #3375

Conversation

CILC98 commented Nov 29, 2025

celm1990 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Labels

4 participants