Skip to content

Fix merge error #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

Fix merge error #495

merged 1 commit into from
Mar 6, 2025

Conversation

leofang
Copy link
Member

@leofang leofang commented Mar 6, 2025

No description provided.

@leofang leofang added this to the cuda.core beta 3 milestone Mar 6, 2025
@leofang leofang requested a review from rwgk March 6, 2025 04:40
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Mar 6, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.
@leofang
Copy link
Member Author

leofang commented Mar 6, 2025

/ok to test
@leofang leofang self-assigned this Mar 6, 2025
@leofang leofang added bug Something isn't working P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Mar 6, 2025
@leofang leofang mentioned this pull request Mar 6, 2025
Merged
rwgk
rwgk approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, how did this slip in? Thanks for the fix!
@leofang
Copy link
Member Author

leofang commented Mar 6, 2025

I merged #458 and #481 b2b without any re-run in-between 😛
@leofang leofang enabled auto-merge March 6, 2025 04:54
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@leofang leofang merged commit 079e177 into NVIDIA:main Mar 6, 2025
76 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuda.core Everything related to the cuda.core module P0 High priority - Must do!
2 participants
@leofang @rwgk