Skip to content

NEW: Create an Event without recording to Stream #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 5, 2025
Merged

NEW: Create an Event without recording to Stream #487

merged 5 commits into from
Mar 5, 2025

Conversation

carterbox
Copy link
Contributor

Closes #485

Adds a method to the Device class which allows you to make an Event without immediately recording it to a Stream.
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Mar 3, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.
@leofang leofang self-requested a review March 3, 2025 22:55
@leofang leofang added P1 Medium priority - Should do feature New feature or request cuda.core Everything related to the cuda.core module labels Mar 3, 2025
@leofang leofang added this to the cuda.core beta 3 milestone Mar 3, 2025
@carterbox
Copy link
Contributor Author

/ok to test
@carterbox carterbox marked this pull request as ready for review March 4, 2025 19:12
@leofang
Copy link
Member

leofang commented Mar 5, 2025

It seems like the copy-pr-bot can only be triggered with "vetter" status (people who have write permission). Let me think about how to set it up for NV folks...

@carterbox LGTM, could you add a release note entry to cuda_core/docs/source/release/0.2.0-notes.rst?
vzhurba01
vzhurba01 reviewed Mar 5, 2025
View reviewed changes
@leofang
Copy link
Member

leofang commented Mar 5, 2025

/ok to test
@leofang leofang enabled auto-merge March 5, 2025 22:52
rwgk
rwgk approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@leofang leofang merged commit 868270c into NVIDIA:main Mar 5, 2025
73 checks passed
@leofang leofang mentioned this pull request Mar 5, 2025
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.
@leofang
Copy link
Member

leofang commented Mar 6, 2025

Thanks, Daniel and all!
@carterbox carterbox deleted the dching/event-from-device branch March 7, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.core Everything related to the cuda.core module feature New feature or request P1 Medium priority - Should do
4 participants
@carterbox @leofang @rwgk @vzhurba01