Skip to content

Add a Linker example #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 1, 2025
Merged

Add a Linker example #475

merged 7 commits into from
Mar 1, 2025

Conversation

vzhurba01
Copy link
Collaborator

close #324
@vzhurba01 vzhurba01 added enhancement Any code-related improvements P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Feb 26, 2025
@vzhurba01 vzhurba01 added this to the cuda.core beta 3 milestone Feb 26, 2025
@vzhurba01 vzhurba01 self-assigned this Feb 26, 2025
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Feb 26, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.
@vzhurba01 vzhurba01 changed the title Add Linker example Feb 26, 2025
@vzhurba01 vzhurba01 changed the title Add a Linker example Feb 26, 2025
@vzhurba01 vzhurba01 changed the title Add a Linker example Feb 26, 2025
@vzhurba01
Copy link
Collaborator Author

/ok to test
@vzhurba01
Copy link
Collaborator Author

Here's what python examples/jit_lto_fractal.py -t all -d displays:
hit_lto_fractal_image
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
ksimpson-work
ksimpson-work reviewed Feb 27, 2025
View reviewed changes
ksimpson-work
ksimpson-work reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@ksimpson-work ksimpson-work left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one little nit, but otherwise it looks good to me. Fractal art engages my monkey brain
ksimpson-work
ksimpson-work reviewed Feb 27, 2025
View reviewed changes
@leofang
Copy link
Member

leofang commented Feb 27, 2025

Thanks, Vlad! I have a local patch that uses LTO-IR instead. I will push but I'd like to come up with a way of showing both approaches (linking all PTXs vs linking 1 PTX with LTO-IRs).
@leofang
Copy link
Member

leofang commented Feb 28, 2025

/ok to test
@leofang
Copy link
Member

leofang commented Feb 28, 2025

CI is green!
rwgk
rwgk reviewed Feb 28, 2025
View reviewed changes
@vzhurba01
Copy link
Collaborator Author

/ok to test
@rwgk
Copy link
Collaborator

rwgk commented Mar 1, 2025

/ok to test
@leofang leofang merged commit 03001e5 into NVIDIA:main Mar 1, 2025
73 checks passed
@leofang
Copy link
Member

leofang commented Mar 1, 2025

Thanks, @vzhurba01 @rwgk!
@leofang leofang mentioned this pull request Mar 3, 2025
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.
@leofang
Copy link
Member

leofang commented Mar 3, 2025

Note: the bot cleanup came too late because I noticed the CPU runners were not accessible when merging to main:
https://github.com/NVIDIA/cuda-python/actions/runs/13606001690/attempts/1
and I had to manually trigger a re-run for failed jobs.
@leofang leofang mentioned this pull request Mar 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.core Everything related to the cuda.core module enhancement Any code-related improvements P0 High priority - Must do!
4 participants
@vzhurba01 @leofang @rwgk @ksimpson-work